Date: Thu, 18 Apr 2002 19:06:41 +0300 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: Gordon Tetlow <gordont@gnf.org>, portmgr@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: [PATCH] bsd.port.mk is broken Message-ID: <3CBEEF11.42410689@FreeBSD.org> References: <200204171349.g3HDnTV73622@freefall.freebsd.org> <Pine.LNX.4.44.0204171603420.26554-100000@smtp.gnf.org> <20020418080234.GF98788@sunbay.com> <3CBED91C.3ED57B68@FreeBSD.org> <20020418152443.GB79334@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote:
[snip]
> > > >
> > > > This broke any port that uses HAS_CONFIGURE (or USE_CONFIGURE, or
> > > > whatever), which adds into the environment INSTALL="/usr/bin/install -c -o
> > > > ${BINOWN} -g ${BINGRP}" which are now undefined now that sys.mk no longer
> > > > includes bsd.own.mk
> > > >
> > > Yeah, it did. Could someone from portmgr@ please commit this patch?
> > >
> > > %%%
> > > Index: bsd.port.mk
> > > ===================================================================
> > > RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
> > > retrieving revision 1.409
> > > diff -u -r1.409 bsd.port.mk
> > > --- bsd.port.mk 4 Apr 2002 10:06:00 -0000 1.409
> > > +++ bsd.port.mk 18 Apr 2002 07:59:17 -0000
> > > @@ -628,6 +628,9 @@
> > > PORTOBJFORMAT!= test -x /usr/bin/objformat && /usr/bin/objformat || echo aout
> > > .endif
> > >
> > > +# Get system defaults.
> > > +.include <bsd.own.mk>
> > > +
> > > MASTERDIR?= ${.CURDIR}
> > >
> > > # If they exist, include Makefile.inc, then architecture/operating
> > > %%%
> >
> > Will it affect 4-STABLE?
> >
> Only after I MFC this stuff.
Mmm, looks like you misunderstood my question or I misformulated it.
What I meant is: whether or not bsd.port.mk with your change will have
any problems on a -STABLE systems without your bsd.xxx.mk stuff MFCed?
As you might know, ports tree isn't branched, so we have to ensure
that *the same* bsd.port.mk does work both on -stable and -current.
-Maxim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CBEEF11.42410689>