Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Oct 2023 08:14:42 +0530
From:      Ravi Pokala <rpokala@freebsd.org>
To:        Martin Matuska <mm@FreeBSD.org>, <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
Subject:   Re: 26103ccba8b7 - main - zfs: enable block cloning by default
Message-ID:  <2D247230-D189-4A43-85A2-0F2442A9CA6A@panasas.com>
In-Reply-To: <202310102247.39AMlsjX018898@gitrepo.freebsd.org>
References:  <202310102247.39AMlsjX018898@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi Martin,

The commit message says "what", not "why".

Why was block cloning disabled by default before, and why is it being enabl=
ed now?

Thanks,

Ravi (rpokala@)

=EF=BB=BF-----Original Message-----
From: <owner-src-committers@freebsd.org <mailto:owner-src-committers@freebs=
d.org>> on behalf of Martin Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org>>
Date: Wednesday, October 11, 2023 at 04:17
To: <src-committers@FreeBSD.org <mailto:src-committers@FreeBSD.org>>, <dev-=
commits-src-all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>, <dev-=
commits-src-main@FreeBSD.org <mailto:dev-commits-src-main@FreeBSD.org>>
Subject: git: 26103ccba8b7 - main - zfs: enable block cloning by default


The branch main has been updated by mm:


URL: https://cgit.FreeBSD.org/src/commit/?id=3D26103ccba8b75038bd83773268524a=
c814bfa334 <https://cgit.FreeBSD.org/src/commit/?id=3D26103ccba8b75038bd837732=
68524ac814bfa334>


commit 26103ccba8b75038bd83773268524ac814bfa334
Author: Martin Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org>>
AuthorDate: 2023-10-10 22:43:35 +0000
Commit: Martin Matuska <mm@FreeBSD.org <mailto:mm@FreeBSD.org>>
CommitDate: 2023-10-10 22:43:35 +0000


zfs: enable block cloning by default


Discussed with: markj
Reviewed by: mav
Tested by: mm (FreeBSD test suite + OpenZFS test suite)
MFC after: 2 months
Differential Revision: https://reviews.freebsd.org/D41991 <https://reviews.=
freebsd.org/D41991>
---
sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c b/sys/c=
ontrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c
index 8969fd6a54bd..09e18de81748 100644
--- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c
+++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c
@@ -89,7 +89,7 @@ int zfs_debug_level;
SYSCTL_INT(_vfs_zfs, OID_AUTO, debug, CTLFLAG_RWTUN, &zfs_debug_level, 0,
"Debug level");


-int zfs_bclone_enabled;
+int zfs_bclone_enabled =3D 1;
SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN,
&zfs_bclone_enabled, 0, "Enable block cloning");









Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2D247230-D189-4A43-85A2-0F2442A9CA6A>