Date: Wed, 26 Oct 2005 19:57:04 +0000 (UTC) From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/net if_vlan.c Message-ID: <200510261957.j9QJv438091618@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
pjd 2005-10-26 19:57:04 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6_0)
sys/net if_vlan.c
Log:
Call if_clone_detach() after vlan_clone_destroy() loop, as if_clone_detach()
is freeing ifc_units field, which is used in
vlan_clone_destroy()->ifc_free_unit().
This fixes panic: ifc_free_unit: bit is already cleared
The fix introduces a small race in that a new interface could be created
between the vlan_clone_destroy() loop and the call to if_clone_detach().
The race is probably too hard to trigger to be worry about it.
This is not an MFC, because better fix was committed to HEAD.
We decided to use this fix, as it is a low-risk fix, which fits just fine
for 6.0 at this stage.
Discussed with: brooks, thompsa
Approved by: re (scottl)
Revision Changes Path
1.79.2.4.2.1 +1 -1 src/sys/net/if_vlan.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510261957.j9QJv438091618>