Date: Wed, 26 Jan 2011 21:51:18 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Mikolaj Golub <to.my.trociny@gmail.com> Cc: freebsd-emulation@freebsd.org, FreeBSD virtualization mailing list <freebsd-virtualization@freebsd.org> Subject: Re: VirtualBox + VIMAGE Message-ID: <20110126215009.T39951@maildrop.int.zabbadoz.net> In-Reply-To: <86ei7z4aps.fsf@kopusha.home.net> References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <20110126091038.C3489@maildrop.int.zabbadoz.net> <86aainkbhb.fsf@zhuzha.ua1> <20110126141636.D3489@maildrop.int.zabbadoz.net> <86ei7z4aps.fsf@kopusha.home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 26 Jan 2011, Mikolaj Golub wrote:
>
> On Wed, 26 Jan 2011 14:18:03 +0000 (UTC) Bjoern A. Zeeb wrote:
>
> BAZ> On Wed, 26 Jan 2011, Mikolaj Golub wrote:
>
> >>
> >> On Wed, 26 Jan 2011 09:15:46 +0000 (UTC) Bjoern A. Zeeb wrote:
> >>
> >> BAZ> I think you should wrap the CURVNET changes in __FreeBSD_version
> >> BAZ> checks so that the port, should it run elsewhere or on older FreeBSDs
> >> BAZ> (if it runs there) not trouble people having to patch it away.
> >>
> >> BAZ> #if defined(__FreeBSD_version) && __FreeBSD_version >= 800500
> >> BAZ> #endif
> >>
> >> BAZ> might be a save bet.
> >>
> >> Thanks. Something like in the patch below?
> >>
> >> Note, I have not run this version yet. Will test it tonight or tomorrow.
>
> BAZ> Well, you will need to include <sys/param.h> as well, and that only if
> BAZ> you are on FreeBSD so you'll need an extra check for just that I
> BAZ> guess. Not sure how vbox handles the all this in their guts.
>
> The file has already had '#include <sys/param.h>' among other includes. It
> just is not seen in the patch. The file is used only for FreeBSD driver so
> there is no need in extra check I think.
Ok, if it's freebsd only, then what you had was fine.
> I have tested this latest version of the patch. It works for me.
Cool. Thanks!
--
Bjoern A. Zeeb You have to have visions!
<ks> Going to jail sucks -- <bz> All my daemons like it!
http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/jails.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110126215009.T39951>