Date: Fri, 18 Dec 2009 10:16:26 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: Dag-Erling =?utf-8?q?Sm=C3=B8rgrav?= <des@des.no>, Ivan Voras <ivoras@freebsd.org> Subject: Re: NOTES checker Message-ID: <200912181016.26573.jhb@freebsd.org> In-Reply-To: <86ljh0bh7b.fsf@ds4.des.no> References: <200912161721.53540.jhb@freebsd.org> <hgdqrv$rbm$2@ger.gmane.org> <86ljh0bh7b.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 18 December 2009 7:27:20 am Dag-Erling Sm=C3=B8rgrav wrote: > Ivan Voras <ivoras@freebsd.org> writes: > > John Baldwin <jhb@freebsd.org> writes: > > > I wrote a little script today that crawls through sys/conf/files*, > > > sys/conf/options*, sys/conf/NOTES, and sys/*/conf/NOTES looking for d= evices > > > or options that are not tested in all the places they are valid. If = folks > > > are interested I can commit it to src/tools. At the moment we have 3= 00+ > > > violations in HEAD. :) The first few look like this: > > What does "tested" mean in this context? >=20 > IIUC, it means "listed in NOTES on all arches that it claims to run on". Yes. It means something like 'LINT builds will test this option'. > > > WARN: device acpi_aiboost is defined globally but only tested in i386= NOTES > > > WARN: device acpi_asus is defined globally but only tested in i386 NO= TES > > > WARN: device acpi_dock is defined globally but only tested in i386 NO= TES > > > WARN: device acpi_fujitsu is defined globally but only tested in i386= NOTES > > > WARN: device acpi_hp is defined globally but only tested in i386 NOTES > > > WARN: device acpi_ibm is defined globally but only tested in i386 NOT= ES > > > WARN: option ACPI_MAX_TASKS is defined globally but never tested > > > WARN: option ACPI_MAX_THREADS is defined globally but never tested > > > WARN: device acpi_panasonic is defined globally but only tested in i3= 86 NOTES > > > WARN: device acpi_sony is defined globally but only tested in i386 NO= TES > > > WARN: device acpi_toshiba is defined globally but only tested in i386= NOTES > > > WARN: device acpi_video is defined globally but only tested in i386 N= OTES > > > WARN: device acpi_wmi is defined globally but only tested in i386 NOT= ES >=20 > The bug here is not that they aren't tested outside i386, but that they > are defined globally (although some of them, perhaps even all, are also > valid on amd64) Yep. Either way it is still "buggy". =2D-=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912181016.26573.jhb>