Date: Sat, 9 Oct 2004 15:13:50 +0000 (UTC) From: Mike Makonnen <mtm@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/lib/libthr/thread thr_mutex.c Message-ID: <200410091513.i99FDoFT001285@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
mtm 2004-10-09 15:13:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) lib/libthr/thread thr_mutex.c Log: ---------------------------- revision 1.32 date: 2004/09/22 18:51:16; author: mtm; state: Exp; lines: +1 -14 Remove vestiges of libthr's signal mangling past. This fixes that last known problem with mysql on libthr: not being able to kill mysqld. ---------------------------- revision 1.31 date: 2004/09/22 16:53:23; author: mtm; state: Exp; lines: +6 -27 The SUSv3 function say that the affected functions MAY FAIL, if the specified mutex is invalid. In spec parlance 'MAY FAIL' means it's up to the implementor. So, remove the check for NULL pointers for two reasons: 1. A mutex may be invalid without necessarily being NULL. 2. If the pointer to the mutex is NULL core-dumping in the vicinity of the problem is much much much better than failing in some other part of the code (especially when the application doesn't check the return value of the function that you oh so helpfully set to EINVAL). ============================================================================= Approved by: re/scottl Revision Changes Path 1.30.2.1 +7 -41 src/lib/libthr/thread/thr_mutex.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410091513.i99FDoFT001285>