Date: Fri, 2 Nov 2018 16:18:58 +0000 From: Brooks Davis <brooks@freebsd.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340055 - in head: share/man/man9 sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/fs/ext2fs sys/fs/fuse sys/fs/nandfs sys/fs/nfs sys/fs/nfsclient sys/fs/tmpfs sys/kern sys/sys sys/uf... Message-ID: <20181102161858.GC79858@spindle.one-eyed-alien.net> In-Reply-To: <bd1ae18c-a899-e290-8911-06e27f49448e@FreeBSD.org> References: <201811021442.wA2EgbVc062099@repo.freebsd.org> <bd1ae18c-a899-e290-8911-06e27f49448e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--qcHopEYAB45HaUaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 02, 2018 at 04:49:00PM +0200, Andriy Gapon wrote: > On 02/11/2018 16:42, Brooks Davis wrote: > > Author: brooks > > Date: Fri Nov 2 14:42:36 2018 > > New Revision: 340055 > > URL: https://svnweb.freebsd.org/changeset/base/340055 > >=20 > > Log: > > Make vop_symlink take a const target path. > > =20 > > This will enable callers to take const paths as part of syscall > > decleration improvements. > > =20 > > Where doing so is easy and non-distruptive carry the const through > > implementations. In UFS the value is passed to an interface that must > > take non-const values. In ZFS, const poisoning would touch code shared > > with upstream and it's not worth adding diffs. >=20 > zfs_vnops.c is already sufficiently different from upstream (because of q= uite > different VFS models), so a small difference in zfs_symlink's signature w= ould > not be too bad. Good to know. When I hit modifying three files I stopped. I'll keep this in the back of my mind as a possible improvement. Thanks, Brooks --qcHopEYAB45HaUaB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJb3HjxAAoJEKzQXbSebgfAcgAH/0SKXqqU3WlIpQvG3m0CFuAw tZbiyp/ZRhrbltGmTps9R8i3cAvc7b7LEDbiUffJdwg7JY+OsdTW2zXHOPHSPMl0 IZDfyYixhCvQhGh0EQq6VZESUB67ff0oz5yg6N/i8f7P8pJbrc1hEz2VpLEPCJhL /fE65yYG/CmuHaHtLEmfU8aWIr/CrNI0SYrfA/V2YCYflugmegG8lT8qO0SdtA0R VdW1EbrawpD14cFgm/3Rg3K+FV6xqbuuGLnLYXNN16d1KRJ0IIpxVsrZsu+7GMHx g5iSFO+xkvD+VETvfkNajwTXjxWpC26TFTuOT1UsQWSlZdIbI6zBe3reJXrdVlo= =p3Up -----END PGP SIGNATURE----- --qcHopEYAB45HaUaB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181102161858.GC79858>