Date: Fri, 26 Feb 2021 14:57:19 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Enji Cooper <yaneurabeya@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database Message-ID: <202102262257.11QMvJsL032239@gndrsh.dnsmgr.net> In-Reply-To: <44c9cd7b-e032-4613-81be-6214f37d2fbe@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > 26 f?vr. 2021 22:41:37 Enji Cooper <yaneurabeya@gmail.com>: > > > > >> On Feb 25, 2021, at 5:27 AM, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > >> > >> The branch main has been updated by bapt: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=2a50a9de8340f08bd876e9e5993332ae14376f80 > >> > >> commit 2a50a9de8340f08bd876e9e5993332ae14376f80 > >> Author:???? Baptiste Daroussin <bapt@FreeBSD.org> > >> AuthorDate: 2021-02-23 16:17:32 +0000 > >> Commit:???? Baptiste Daroussin <bapt@FreeBSD.org> > >> CommitDate: 2021-02-25 13:25:32 +0000 > >> > >> ?? terminfo: add terminfo database > >> > >> ?? Tested by:????? manu, jbeich > > > > Hi Baptiste, > > ? A question and a comment: > > ? 1. Was this reviewed in Phabricator? > > ? 2. The details on why the terminfo database is being added are a bit lean too to non-Unix users. It would be nice if the motivation for the change was documented in the commit message. > > Thanks! > > -Enji > > No it was not reviewed in phabricator as it does not really bring any code, but it was discussed on the mailing lists with a heads up on the plan and the motivation, and all the reaction were in favor of this change. On what mailing list as I do not recall such a thread, which means I probably need to add yet another list. > Note thay while it could have been better written this commit is the third of a serie, where the first one explain a bit more things. > > Bapt -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102262257.11QMvJsL032239>