Date: Sat, 10 Apr 2021 11:27:54 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Kristof Provost <kp@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 0dd13c77432a - main - libnv: Build PIC Message-ID: <20210410152754.4isx26qyvz6k3qbo@mutt-hbsd> In-Reply-To: <202104100916.13A9GMOp069019@gitrepo.freebsd.org> References: <202104100916.13A9GMOp069019@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--bn3s3dhmbz3p573s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 10, 2021 at 09:16:22AM +0000, Kristof Provost wrote: > The branch main has been updated by kp: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0dd13c77432ade1ae94c9661cb= ad5537e3e6ab1d >=20 > commit 0dd13c77432ade1ae94c9661cbad5537e3e6ab1d > Author: Kristof Provost <kp@FreeBSD.org> > AuthorDate: 2021-04-02 15:06:02 +0000 > Commit: Kristof Provost <kp@FreeBSD.org> > CommitDate: 2021-04-10 09:16:01 +0000 >=20 > libnv: Build PIC > =20 > Build libnv as position independent code so we can use it from shared > libraries. > =20 > MFC after: 4 weeks > Sponsored by: Rubicon Communications, LLC ("Netgate") > Differential Revision: https://reviews.freebsd.org/D29561 > --- > lib/libnv/Makefile | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/libnv/Makefile b/lib/libnv/Makefile > index b13758931c4e..854cd2c7f3f3 100644 > --- a/lib/libnv/Makefile > +++ b/lib/libnv/Makefile > @@ -10,6 +10,7 @@ SHLIB_MAJOR=3D 0 > =20 > .PATH: ${SRCTOP}/sys/contrib/libnv ${SRCTOP}/sys/sys > CFLAGS+=3D-I${.CURDIR} > +CFLAGS+=3D-fPIC Wouldn't the better fix be renaming LIB to SHLIB like every other PIC lib? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --bn3s3dhmbz3p573s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBxw/gACgkQ/y5nonf4 4fqb9Q//QQXXForXJWJb9XCneQhDkG+++fMY8Qyfed7UJCZ8exmk9GPl9TiQgt+h tX62sdpSqTUCHXlXd+xa+zUc/RvXz8vBXXTtNRIlkaNuP1HWCkioS0QQ+u5Or4NP VQFsBnysiynLzd9WEl/fykA2O9vQ7lVjs0HOsl2KDp6pG13/k2kAG7XPg7ZHezrq qDsrAkrIaYVK5BTltVZghv/l5ZsbYJo8mYfYgbKBZocceMw20HaR7uHvbRt3C6Ju efvrBOpzcdaeZG/WU+chm+r7yh80pWQuCrg7sFgc+/6Q6ZWrz8zazxKG4UK3pb/L DPm6ThozdlC3+mc3naIHgK6dXtgh41avTvU/dl4ZGtliuSUfUR1NHQmZ41/hZTGK JM/4socOUOCw6e+llK2cgFsFwOzHup5xbyb2CeCnH/MSqgmCyC1RaPenkqrzSVmq HTJjDVxyhT3UTycIak6NFmDbja9MAu6Sw0KSiVCfAH6T/vThzxqKs35vS09AAJ0m Xz3qpSKylYuwkKlX2OCeFVizfd7cg4Z2tLIilyVjZuiQZjDu1UksSFSXFKwbjZCz tBTefSnat4SDh42mXl2BPJ7NbzySthtqAx5s5QtYNwnFMAhOhKtEdlojqjLGuU9I TkHqnPHTJ6jDNdFUi+3YdkXSp06Kc/JfNMpSWj1LX54xPwPDvRg= =th8p -----END PGP SIGNATURE----- --bn3s3dhmbz3p573s--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210410152754.4isx26qyvz6k3qbo>