Date: Tue, 14 Apr 2026 12:53:50 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4fadf2466468 - main - tcp_close: Use in6_pcbdisconnect for INET6 sockets Message-ID: <ad6bTvy4oJlUVFmX@cell.glebi.us> In-Reply-To: <1fcc8e29-5a8c-4596-91d9-8212ff8cc379@FreeBSD.org> References: <69de895e.398d0.7253ff8b@gitrepo.freebsd.org> <ad6WC94osTHMGc5Y@cell.glebi.us> <1fcc8e29-5a8c-4596-91d9-8212ff8cc379@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On Tue, Apr 14, 2026 at 03:42:03PM -0400, John Baldwin wrote: J> > J> URL: https://cgit.FreeBSD.org/src/commit/?id=4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> > J> J> > J> commit 4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 J> > J> Author: John Baldwin <jhb@FreeBSD.org> J> > J> AuthorDate: 2026-04-14 18:07:51 +0000 J> > J> Commit: John Baldwin <jhb@FreeBSD.org> J> > J> CommitDate: 2026-04-14 18:07:51 +0000 J> > J> J> > J> tcp_close: Use in6_pcbdisconnect for INET6 sockets J> > J> J> > J> This also fixes the LINT-NOINET builds. J> > J> J> > J> Fixes: 40dbb06fa73c ("inpcb: retire INP_DROPPED and in_pcbdrop()") J> > J> > Thanks! I wonder how did it pass the tests. Looks like we don't have J> > any UDPv6 tests? J> J> If you look at in_pcbdisconnect and in6_pcbdisconnect they are mostly the same and J> given that it was a close operation about to discard the pcb anyway, the differences J> probably didn't matter in practice. I only noticed due to make tinderbox being broken. Indeed, since after this path socket can't be reused assignment to IPv4 part of the union was harmless for IPv6. -- Gleb Smirnoffhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ad6bTvy4oJlUVFmX>