Date: Thu, 4 Jun 2026 14:09:40 -0700 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Olivier Certner <olce@freebsd.org> Cc: Enji Cooper <ngie@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@freebsd.org> Subject: Re: git: 886164895f3f - main - amd64: complete thunderbolt KERNCONF integration Message-ID: <4316E349-244A-4F3E-9D4B-538EE4B0F037@gmail.com> In-Reply-To: <3174612.hHqAuc6tWs@ravel> References: <6a1fc36c.20f4d.2792bff2@gitrepo.freebsd.org> <86wlwgue2o.fsf@ltc.des.dev> <3174612.hHqAuc6tWs@ravel>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Jun 3, 2026, at 9:06 AM, Olivier Certner <olce@freebsd.org> wrote: > > Hi Enji, > >>> commit 886164895f3f4805dc11171ac7980acaccf6ec77 >>> Author: Enji Cooper <ngie@FreeBSD.org> >>> AuthorDate: 2026-06-03 06:02:01 +0000 >>> Commit: Enji Cooper <ngie@FreeBSD.org> >>> CommitDate: 2026-06-03 06:02:01 +0000 >>> >>> amd64: complete thunderbolt KERNCONF integration >>> >>> This completes the work so the driver can be integrated into KERNCONFs >>> properly on amd64. >>> >>> MFC after: 1 month >>> >>> Differential Revision: https://reviews.freebsd.org/D55573 >> >> /usr/src/sys/dev/thunderbolt/router.c:281:6: error: variable 'up' set but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/router.c:723:8: error: variable 'adap' set but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/nhi.c:837:20: error: variable 'sc' set but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/nhi.c:871:20: error: variable 'sc' set but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/nhi.c:874:8: error: variable 'len' set but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/tb_acpi_pcib.c:123:15: error: variable 's' set but not used [-Werror,-Wunused-but-set-variable] >> /usr/src/sys/dev/thunderbolt/tb_pcib.c:307:6: error: variable 'error' set but not used [-Werror,-Wunused-but-set-variable] > > Compilation fails on INVARIANTS, it works with !INVARIANTS. Was bitten by such a case relatively recently. Try not to forget to build both cases when fiddling with debug code. > > Fixed in 9a133eee1ed9cf32. Amend as you see fit. Thank you Olivier. I’m kind of surprised that __diagused didn’t work, but what you did is the right thing to do in this case. I’ll MFC your change as well when the time comes to MFC my original change. Cheers, -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmoh6ZQACgkQGpE5DjPs NJg/bw//WtGPrMjKrOyQPrzR0lXtOfrbWP4/JEIpyTl06UA9qGu/zGzdJQwcrvwM J6ilkjnb1vs3akG9raVVuiJm7jEjQP7RvQPyVM8eCqNMa9S4RZBwUEF4hjCX0hkO fUsILExXj/S3ztH5PIDq/1Axk5A49gD/WKZmUW4wEc/OQaE7JGlMtaG9k9HV1Kh6 BmlsN55MWjAS43XrkBbsMbJpSWBE3pfdiH6i460DMDstZ6r2fdky9ULWugDUvDvW 1i0I3kMh4qji8oXoc1WANum5DMLMWF5xw00lRD420yOsxKGna9E1OUZsn3sCfIEy UEb52h7Jv5LyckABYW15h04yJkfP62UdlYYcA4mPpUaJrNFZ21Cteamb/qIPWm4r K0UE1n3ScX0gu33bwiZcyzsj4hTHMCWgVOaEygE9xZfZUcWJVSnj1GjQFZ7qHyqR DnM3wGjk6ar9LWGUesltiKV2pbUfNpfOI1MXW56Lvqat165FFsEMnlH75OX9ldha NhKRvsbN6W3s+Gv33SljkEj/atooxx3S0jWIxHL+7CCGhKXU7K54qFxV5tdeDrax 8gIgTvMq7SSiWaMGSrnUh322zKWljJKkVixr42/GAlFklA0S59I/rqol/m6j0FVm owYQ8gP0SnjoNnZeoL45kyrw7/JraGRtYglt51PJbh22yGZAMKU= =R0tR -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4316E349-244A-4F3E-9D4B-538EE4B0F037>