Date: Thu, 21 Aug 2025 10:51:53 -0600 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: Toomas Soome <tsoome@me.com>, A FreeBSD User <freebsd@walstatt-de.de>, "Simon J. Gerraty" <sjg@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: b44cc1b479fe - main - loader: do not try to open directories with TFTP Message-ID: <CANCZdfo3w%2BBaU3bHr1xcb%2BK-bGf%2Bn4ZiqttcuGg3ZMGCG2MsjA@mail.gmail.com> In-Reply-To: <pr80008p-o76s-7657-702n-09n06554r7q9@SerrOFQ.bet> References: <202508202248.57KMmcTO016280@gitrepo.freebsd.org> <20250821060752.001c9599@thor.sb211.local> <8006s3o4-3nns-509q-n89q-oq88r8o09sn8@SerrOFQ.bet> <9EEDE524-1ED3-4F41-9584-460DCBF61D81@me.com> <pr80008p-o76s-7657-702n-09n06554r7q9@SerrOFQ.bet>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000b0b77a063ce2e872 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 21, 2025 at 1:02=E2=80=AFAM Bjoern A. Zeeb <bz@freebsd.org> wro= te: > On Thu, 21 Aug 2025, Toomas Soome wrote: > > >> shot in the dark (haven't checked that LOADER_NET_SUPPORT would be > defined for these files): > > > > > > I do not think it is the approach you want to take there, because this > means you would need to build all those variants to build different > components=E2=80=A6 > > > > I would think of having weak is_tftp() implementation returning false > for case the dev_net.c is not built or move dev_net.c into libsa. I=E2=80= =99m not > quite sure why dev_net.c is outside libsa anyhow;) > > Even just moving is_tftp into stand.h would work. > Even better: deleting it entirely. It's not a good solution to the problem. But it's a better solution than what we had before. It will be gone when I do my next loader tech debt reduction pass. I didn't have time to do that before the release, so simon's changes went in. He's since committed an adequate fix. Warner --000000000000b0b77a063ce2e872 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g= mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Aug 21,= 2025 at 1:02=E2=80=AFAM Bjoern A. Zeeb <<a href=3D"mailto:bz@freebsd.or= g">bz@freebsd.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote"= style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p= adding-left:1ex">On Thu, 21 Aug 2025, Toomas Soome wrote:<br> <br> >> shot in the dark (haven't checked that LOADER_NET_SUPPORT woul= d be defined for these files):<br> ><br> ><br> > I do not think it is the approach you want to take there, because this= means you would need to build all those variants to build different compon= ents=E2=80=A6<br> ><br> > I would think of having weak is_tftp() implementation returning false = for case the dev_net.c is not built or move dev_net.c into libsa. I=E2=80= =99m not quite sure why dev_net.c is outside libsa anyhow;)<br> <br> Even just moving is_tftp into stand.h would work.<br></blockquote><div><br>= </div><div>Even better: deleting it entirely. It's not a good solution = to the problem. But it's a better solution than what we had before. It = will be gone when I do my next loader tech debt reduction pass. I didn'= t have time to do that before the release, so simon's changes went in. = He's since committed an adequate fix.</div><div><br></div><div>Warner= =C2=A0</div></div></div> --000000000000b0b77a063ce2e872--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo3w%2BBaU3bHr1xcb%2BK-bGf%2Bn4ZiqttcuGg3ZMGCG2MsjA>