Date: Tue, 19 Feb 2008 22:51:55 +0100 From: Roman Divacky <rdivacky@freebsd.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: emulation@freebsd.org Subject: Re: [PATCH]: mremap() trivial fixes Message-ID: <20080219215155.GA34405@freebsd.org> In-Reply-To: <20080217193950.GQ57756@deviant.kiev.zoral.com.ua> References: <20080217163228.GA83107@freebsd.org> <20080217193950.GQ57756@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 17, 2008 at 09:39:50PM +0200, Kostik Belousov wrote: > On Sun, Feb 17, 2008 at 05:32:28PM +0100, Roman Divacky wrote: > > hi > > > > www.vlakno.cz/~rdivacky/linux_misc.patch > > > > fixes two trivial issues with mremap(). it sanitizes > > the input params a little thus fixing two LTP fails > > > > please commit > > Please, supply the commit message. > Also, the comment about Linux/FreeBSD meaning of the PAGE_MASK shall be > adjusted to describe the reason for the check first (I suggest simply > add the "Check for the page alignment" there). commit message: Sanitize arguments to linux_mremap(). Check for MREMAP_FIXED and MREMAP_MAYMOVE flags being mutually exclusive and page alignment of addr argument. and I fully agree with the change of the comment. please commit. thnx a lot roman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080219215155.GA34405>