Date: Fri, 7 Jan 2011 18:06:52 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Anonymous <swell.k@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217101 - head/lib/libcompiler_rt Message-ID: <20110107160652.GY12599@deviant.kiev.zoral.com.ua> In-Reply-To: <8662u0ycsz.fsf@gmail.com> References: <201101071435.p07EZkNU055560__46495.048949919$1294410977$gmane$org@svn.freebsd.org> <8662u0ycsz.fsf@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, Jan 07, 2011 at 06:05:16PM +0300, Anonymous wrote: > Konstantin Belousov <kib@FreeBSD.org> writes: > > > Author: kib > > Date: Fri Jan 7 14:35:45 2011 > > New Revision: 217101 > > URL: http://svn.freebsd.org/changeset/base/217101 > > > > Log: > > On amd64 and i386, force assembler to mark objects compiled from the > > assembler source for libcompiler_rt as not needed executable stack. This > > is done with a hammer instead of properly marking each assembly file > > with section .note.GNU-stack to avoid modifying contributed source. > > > > Discussed with: ed > > > > Modified: > > head/lib/libcompiler_rt/Makefile > > > > Modified: head/lib/libcompiler_rt/Makefile > > ============================================================================== > > --- head/lib/libcompiler_rt/Makefile Fri Jan 7 14:32:29 2011 (r217100) > > +++ head/lib/libcompiler_rt/Makefile Fri Jan 7 14:35:45 2011 (r217101) > > @@ -156,4 +156,10 @@ SYMLINKS+=libcompiler_rt_p.a ${LIBDIR}/l > > . endif > > .endif > > > > +.if ${MACHINE_CPUARCH} == "amd64" || ${MACHINE_CPUARCH} == "i386" > > +AFLAGS+=--noexecstack > > +ACFLAGS+=-Wl,a,--noexecstack > > +.endif > > Typo? -Wl,a,--foo vs. -Wa,--foo. From gcc(1) manpage > > Assembler Option > -Wa,option -Xassembler option > > Linker Options > -Wl,option -Xlinker option Thank you. Should be fixed in r217102. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0nOhsACgkQC3+MBN1Mb4jCTACdHTxRpNpkOknLPxTjKg8VzGqR XIoAn1O6dU1kMTuz2mCMyfKyUv9/5fn/ =ON1C -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110107160652.GY12599>