Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Oct 2012 11:41:06 -0700
From:      Adrian Chadd <adrian@freebsd.org>
To:        Jim Harris <jimharris@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r242014 - head/sys/kern
Message-ID:  <CAJ-VmonpdJ445hXVaoHqFgS0v7QRwqHWodQrVHm2CN9T661www@mail.gmail.com>
In-Reply-To: <201210241836.q9OIafqo073002@svn.freebsd.org>
References:  <201210241836.q9OIafqo073002@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 24 October 2012 11:36, Jim Harris <jimharris@freebsd.org> wrote:

>   Pad tdq_lock to avoid false sharing with tdq_load and tdq_cpu_idle.

Ok, but..


>         struct mtx      tdq_lock;               /* run queue lock. */
> +       char            pad[64 - sizeof(struct mtx)];

.. don't we have an existing compile time macro for the cache line
size, which can be used here?



Adrian



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonpdJ445hXVaoHqFgS0v7QRwqHWodQrVHm2CN9T661www>