Date: Sat, 27 Mar 2010 12:03:00 -0400 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Doug Barton <dougb@freebsd.org> Cc: osa@freebsd.org, apache@freebsd.org Subject: Re: %%RC_SUBR%% code in apache and nginx Message-ID: <4BAE2C34.60202@p6m7g8.com> In-Reply-To: <4BAD62C7.2050302@FreeBSD.org> References: <4BAD62C7.2050302@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/26/2010 9:43 PM, Doug Barton wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: RIPEMD160
>
> Howdy,
>
> I am working on deprecating %%RC_SUBR%% and noticed the following:
>
> www/apache20/files/apache2.sh.in:
> %%PREFIX%%/etc/rc.d/apache2%%RC_SUBR_SUFFIX%% $1 ${profile}
> www/apache13-modssl/files/apache.in:
> %%PREFIX%%/etc/rc.d/apache%%RC_SUBR_SUFFIX%% $1 ${profile}
> www/nginx-devel/files/nginx.sh.in:
> %%PREFIX%%/etc/rc.d/nginx%%RC_SUBR_SUFFIX%% $1 ${profile}
> www/nginx/files/nginx.sh.in:
> %%PREFIX%%/etc/rc.d/nginx%%RC_SUBR_SUFFIX%% $1 ${profile}
>
> I'm not 100% sure what the goals for that code are, but you might want
> to review it with the goal of at minimum removing %%RC_SUBR%%. Also, the
> value of RC_SUBR_SUFFIX is empty on all supported versions of FreeBSD,
> and has been for some time. Anything you can do to simplify and/or
> eliminate that code would be greatly appreciated.
>
Yes, I've previously removed it from www/apache22. I've been explicitly
asked by portmgr@ to not make these changes though unless its bundled
with other updates in the past.
Go forth and change it!
--
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer, FreeBSD Foundation
Sr. System Admin, Ridecharge Inc.
Consultant, P6M7G8 Inc.
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BAE2C34.60202>