Date: Fri, 27 Jan 2012 12:30:58 GMT From: Pierre Imai <pierre@imai.at> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/164538: [patch] add support for newer Lenovo ThinkPads to acpi_ibm Message-ID: <201201271230.q0RCUwdl095387@red.freebsd.org> Resent-Message-ID: <201201271240.q0RCeAA5084152@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 164538
>Category: kern
>Synopsis: [patch] add support for newer Lenovo ThinkPads to acpi_ibm
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Jan 27 12:40:10 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Pierre Imai
>Release: 9.0-stable
>Organization:
>Environment:
FreeBSD X.Y.net 9.0-STABLE FreeBSD 9.0-STABLE #0: Fri Jan 20 20:52:52 CET 2012 root@X.Y.net:/usr/obj/data/usr/src/sys/COMMON-AMD64 amd64
>Description:
The acpi_ibm kernel module does not include the ID used by newer Lenovo Laptops (basically, "IBM0086" was replaced by "LEN0086"). Adding the new string to the ibm_ids struct in acpi_ibm.c allows the driver to attach and work properly. Tested during daily use on a ThinkPad W520 running 9.0-stable AMD64 since Nov 2011.
>How-To-Repeat:
Try "kldload ibm_acpi" on e.g. a Lenovo ThinkPad W520, the driver will not recognize the ACPI ID.
>Fix:
Replace line 293 of
sys/dev/acpi_support/acpi_ibm.c:
--- /usr/src/sys/dev/acpi_support/acpi_ibm.c.old 2012-01-27 13:18:19.000000000 +0100
+++ /usr/src/sys/dev/acpi_support/acpi_ibm.c 2012-01-27 13:19:32.000000000 +0100
@@ -290,7 +290,7 @@
DRIVER_MODULE(acpi_ibm, acpi, acpi_ibm_driver, acpi_ibm_devclass,
0, 0);
MODULE_DEPEND(acpi_ibm, acpi, 1, 1, 1);
-static char *ibm_ids[] = {"IBM0068", NULL};
+static char *ibm_ids[] = {"LEN0068", "IBM0068", NULL};
static void
ibm_led(void *softc, int onoff)
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201271230.q0RCUwdl095387>