Date: Mon, 11 Mar 2024 08:42:54 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Vladimir Druzenko <vvd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 79f8f9c8f54b - main - */*: convert Makefile patches to MAKE_ARGS after "Move man pages to share/man" Message-ID: <equjhvaadbyvrm73z7aqlcix2crkzyj4tez5wtbgvxobuifvci@enk3zp4g2g3v> In-Reply-To: <202403102258.42AMwcEk042464@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sun, Mar 10, 2024 at 10:58:38PM +0000, Vladimir Druzenko wrote: > The branch main has been updated by vvd: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=79f8f9c8f54b8de3d324d30ce9a19649bbe69e69 > > commit 79f8f9c8f54b8de3d324d30ce9a19649bbe69e69 > Author: Vladimir Druzenko <vvd@FreeBSD.org> > AuthorDate: 2024-03-10 22:49:41 +0000 > Commit: Vladimir Druzenko <vvd@FreeBSD.org> > CommitDate: 2024-03-10 22:49:41 +0000 > > */*: convert Makefile patches to MAKE_ARGS after "Move man pages to share/man" > > Replaced patches for Makefiles with "MAKE_ARGS+=MANDIR=${PREFIX}/share/man" Why += ? Is the variable defined before in the Makefile ? If it is, then you should append to its previous value, if it is not, += will only confuse people in the future, wondering why a non existing variable is appended to instead of being set. -- Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXutf1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6F7Qv/a5tdYS3Zo+5phO7rmJTUUwpWiOXwhFEK9glPxYOqxkcXwvY5E/BMyFLc WhzuFuCaUHqykB96HYf7Pjmev4DzeM4izYym/NSacc5ubhbloaG3WQrv6kgHZXrB JL6QtYDQm+wg4XH4vEm7Jwd1GjjVPH0shZ3Xffk/UeQacjym15BbLHwyL/wb34su eyXzBPExwmJIQT0sWd7AMveM8sKi4p2L9dZdwwNiCws+iKjMEHtYiDaOwKG0w1TB okfw6CxEqbYmK5MHamMTJ30qAsreN4ltNrtc45F1oiWSGjYRan2pRTIUZtVIGcjT 95Rnfe7qM617gqpP8faT9fWxX6mtvCmsCs30tnAt2joCh1lKnb8PYukiX1q5grsz E4ayr7VUQ5xJWkuj+g4V34v+KSfA5U59EGA/vDWzCD67of/hihNjHnUiigXEmXK/ EcR+A3M8F2HsPIs9BlPhyvlPhb4gbWqpjGJXezWh/50rgK5PgERF/NQL+NVzj56m e1JF9uV6 =N6DB -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?equjhvaadbyvrm73z7aqlcix2crkzyj4tez5wtbgvxobuifvci>