Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Feb 2021 10:36:23 +0800
From:      Li-Wen Hsu <lwhsu@freebsd.org>
To:        Daniel Ebdrup Jensen <debdrup@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: bc3bba70d834 - main - inetd: Add examples from manual page and other sources
Message-ID:  <CAKBkRUyPK9oPdHmkHsekFeLWnyZ4dLd=Foep7zsCwsQ0q95g9g@mail.gmail.com>
In-Reply-To: <202102261907.11QJ7Oaq039195@gitrepo.freebsd.org>
References:  <202102261907.11QJ7Oaq039195@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 27, 2021 at 3:07 AM Daniel Ebdrup Jensen
<debdrup@freebsd.org> wrote:
>
> The branch main has been updated by debdrup (doc committer):
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=bc3bba70d834c169475302334b192bc90c17521e
>
> commit bc3bba70d834c169475302334b192bc90c17521e
> Author:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
> AuthorDate: 2021-02-26 19:05:46 +0000
> Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
> CommitDate: 2021-02-26 19:07:03 +0000
>
>     inetd: Add examples from manual page and other sources
...
>     Reviewed by:    kevans, brueffer, lwhsu, yuripv

This is very minor, but for the record, I didn't click "accept" so I
am a bit hesitant to be listed in the "Reviewed by" line because I
think it implies I have reviewed everything and meet my standard to
commit myself.

I was just commenting on some very tiny stuff and help. I support the
changes but I don't think my contribution is sufficient as a reviewer.
I don't even list myself in the reviewers field in the differential.

>     Differential Revision:  https://reviews.freebsd.org/D28882
...
> diff --git a/usr.sbin/inetd/inetd.conf b/usr.sbin/inetd/inetd.conf
> index 65a3507a6dc2..7f5f6783a038 100644
> --- a/usr.sbin/inetd/inetd.conf
> +++ b/usr.sbin/inetd/inetd.conf
...
> +# Example entry for insecure rsync server
> +# This is best combined with a VTI like if_ipsec(4) or wg(4)

As we discussed in the differential, we can put if_wg(4) here, and
they can be MFC'd together.

BTW, still thanks very much for you to work on this!

Best,
Li-Wen



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUyPK9oPdHmkHsekFeLWnyZ4dLd=Foep7zsCwsQ0q95g9g>