Date: Sat, 21 Jul 2007 15:11:10 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: chinsan <chinsan.tw@gmail.com> Cc: doc-committers@FreeBSD.org, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/porters-handbook book.sgml Message-ID: <1185023470.34939.13.camel@ikaros.oook.cz> In-Reply-To: <1f27304c0707210437u4c6994aeg3975a8f932645400@mail.gmail.com> References: <200707201246.l6KCkC8M062760@repoman.freebsd.org> <1184936122.13381.28.camel@pav.hide.vol.cz> <1f27304c0707200606s32541002g488f2f1a92ff8f21@mail.gmail.com> <1184937122.13381.34.camel@pav.hide.vol.cz> <1f27304c0707210437u4c6994aeg3975a8f932645400@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-Vp+uMmvgPsNeZT+2mt/H
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
chinsan p=ED=B9e v so 21. 07. 2007 v 19:37 +0800:
> On 7/20/07, Pav Lucistnik <pav@freebsd.org> wrote:
> > chinsan p=ED=B9e v p=E1 20. 07. 2007 v 21:06 +0800:
>=20
> > > Since "PTHREAD_LIBS?=3D -pthread", so why we should replace it again?
> > > Therefore, it was guessed as a typo of "-lpthread" instead of "-pthre=
ad".
> > > Because PTHREAD_LIBS =3D -pthread. :)
> > >
> >
> > People are supposed to patch s|-pthread|${PTHREAD_LIBS}| too, because
> > PTHREAD_LIBS are not guaranteed to be equal to -pthread forever.
> >
>=20
>=20
> So...according to what you means,
> we should update the "12.12 Threading libraries" section....?
This chapter you quoted is 100% correct as it is.
You basically went on and gratuitously changed a REINPLACE_CMD example.
The old example was just fine.
> "12.12 Threading libraries
>=20
> The threading library must be linked to the binaries using a special
> linker flag -pthread on FreeBSD. If a port insists on linking
> -lpthread or -lc_r directly, patch it to use PTHREAD_LIBS variable
> provided by the ports framework. This variable usually has the value
> of -pthread, but on certain architectures and FreeBSD versions it can
> have different values, so do not just hardcode -pthread into patches
> and always use PTHREAD_LIBS.
>=20
> Note: If building the port errors out with unrecognized option
> '-pthread' when setting PTHREAD_LIBS, it may be desirable to use gcc
> as linker by setting CONFIGURE_ENV to LD=3D${CC}. The -pthread option is
> not supported by ld directly.
> "
>=20
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
But soft, what light through yonder window breaks? It is the East,
and Juliet is the sun! Arise, fair sun, and kill the envious moon,
who is already sick and pale with grief that thou her maid art far
more fair than she.
--=-Vp+uMmvgPsNeZT+2mt/H
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQBGogXuntdYP8FOsoIRAmY+AJ9W/c0RksEduYoKDO/rRZ1O2N5weQCfck/+
LdAR9Ck23J8Pk+0DTwX90aE=
=D45e
-----END PGP SIGNATURE-----
--=-Vp+uMmvgPsNeZT+2mt/H--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1185023470.34939.13.camel>