Date: Tue, 25 Apr 2000 18:33:07 +0200 (CEST) From: Remy Nonnenmacher <remy@boostworks.com> To: csg@waterspout.com Cc: archie@whistle.com, julian@elischer.org, pavel@alum.mit.edu, nsayer@sftw.com, luigi@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: Proposal for ethernet, bridging, netgraph Message-ID: <200004251632.SAA40157@luxren2.boostworks.com> In-Reply-To: <20000425105926.A518@waterspout.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Apr, C. Stephen Gunn wrote: > On Mon, Apr 24, 2000 at 07:14:44PM -0700, Archie Cobbs wrote: > >> OK, here's a patch ready for review & test.. this patch does one >> thing, which is move the calls to BPF and BRIDGE'ing out of each >> Ethernet driver and into ether_input(). > > Why not also modify ether_input() to remove the Ethernet header > when appropriate? Instead of the monkey business to add the Ethernet > Header back on. > > There are a couple of places in ether_input() that do this already, > and you're proposing another for passing the packet to bpf. > > I proposed this a few weeks ago, but never cleaned up my patch > for submission. <sigh> > > It would certainly prevent some of the kludges to deal with the > Ethernet Header for things that want a peek at it, like VLANs. > That's correct. the patch break the bridging due to the ether header ripping. It would be preferable (at least for speeding up bridging) to adjust the packet after all bridging/BPF stuff. RN. ItM To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200004251632.SAA40157>