Date: Thu, 25 Apr 2002 16:30:02 -0700 (PDT) From: Gregory Carvalho <GregoryC@stcinc.com> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/37013: ls directory name output trailing slash duplcation- PATCH Message-ID: <200204252330.g3PNU2V02686@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/37013; it has been noted by GNATS. From: Gregory Carvalho <GregoryC@stcinc.com> To: Maxim Konovalov <maxim@macomnet.ru> Cc: bug-followup@freebsd.org Subject: Re: bin/37013: ls directory name output trailing slash duplcation- PATCH Date: Thu, 25 Apr 2002 16:25:45 -0700 Maxim Konovalov wrote: > > Have you seen bin/33187? > > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/33187 I apologize for my oversight. Perhaps the compact patch I provided sufficiently addresses the concerns expressed in the thread related to bin/33187. 1) Color settings remain unaffected by bin/37013. 2) The code style of bin/37013 maintains consistency with the original ls.c. 3) bin/37013 doesn't break ``ls -dF /''. 4) Symlinks operate properly with bin/37013. 5) While bin/37013 does not truncate the output of ``ls -dF /usr////////////////'' to /usr/, it resrticts ls(1) from appending an additional, illegitimate /. 6) bin/37013 is a minimal patch, and I anticipate negligible performance impact; in other words, bin/37013 could still be interpreted as "overloading" the utilites. I recognize bin/33187 addressed some of these issues, but, in my opinion, item 5 above is the weakest link for bin/37013. With respect, Gregory Carvalho To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204252330.g3PNU2V02686>