Date: Thu, 22 Aug 2013 14:06:52 +0400 From: Andrey Chernov <ache@freebsd.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Sergey Kandaurov <pluknet@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r254600 - head/lib/libutil Message-ID: <5215E2BC.3070904@freebsd.org> In-Reply-To: <5215E16E.4080207@freebsd.org> References: <201308211646.r7LGk6eV051215@svn.freebsd.org> <5214F72B.7070006@freebsd.org> <20130821190309.GB52908@omg> <20130821202725.GA4991@stack.nl> <20130821212413.GC52908@omg> <20130821213755.GA8052@stack.nl> <5215E16E.4080207@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22.08.2013 14:01, Andrey Chernov wrote:
> On 22.08.2013 1:37, Jilles Tjoelker wrote:
>>> if (number == UINTMAX_MAX && errno == ERANGE) {
>>> return (-1);
>>> }
>>>
>>> + if (errno == 0)
>>> + errno = saved_errno;
>>> +
>> This looks good to me.
>>
>
> Just being nitpicking) number == UINTMAX_MAX check is unneeded.
>
Sorry for misguiding, forget it.
The check is needed, other functions inside strtoumax() (FIX_LOCALE,
isspace) may set errno in theory.
--
http://ache.vniz.net/
bitcoin:1G6ugdNY6e5jx1GVnAU2ntj2NEfmjKG85r
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5215E2BC.3070904>