Date: Fri, 26 Dec 2003 13:26:46 -0500 From: "Brian F. Feldman" <green@FreeBSD.org> To: Sam Leffler <sam@errno.com> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c Message-ID: <200312261826.hBQIQkAX060681@green.bikeshed.org> In-Reply-To: Message from Sam Leffler <sam@errno.com> of "Fri, 26 Dec 2003 10:25:07 PST." <200312261025.07395.sam@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sam Leffler <sam@errno.com> wrote: > On Friday 26 December 2003 10:09 am, Brian Feldman wrote: > > green 2003/12/26 10:09:35 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/net if.c > > Log: > > Don't truncate the interface name in ifunit(). It's now possible to > > query "very long interface names", e.g.: > > ndis_atheros0: flags=8847<UP,BROADCAST,DEBUG,RUNNING,SIMPLEX,MULTICAST> > > mtu 1500 > > I'm not sure this works out well as I believe user-level apps like netstat > assume interface names are short max-lengthed strings. I've been using the > ndis stuff (great work btw) and was thinking instead that it would be nice to > customize the device by specifying the name at config time. > > I think you need to discuss changes like this before committing them. They are still short max-length strings. ifunit() wasn't accounting for the "dev/" it was appending when it searches for a given interface, so it was limiting things to IFNAMSIZE - 4 accidentally. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312261826.hBQIQkAX060681>