Date: Sun, 12 Mar 2017 05:36:16 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Li-Wen Hsu <lwhsu@FreeBSD.org> Subject: Re: svn commit: r308996 - head/lib/libfetch Message-ID: <20170312043615.ax5a6xtuf2zmebc2@ivaldir.net> In-Reply-To: <867f468rx5.fsf@desk.des.no> References: <201611221330.uAMDU7fg052989@repo.freebsd.org> <77B1B45A-D837-4853-B1E9-958D3B0DD519@lists.zabbadoz.net> <867f468rx5.fsf@desk.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Fri, Mar 03, 2017 at 01:29:26PM +0100, Dag-Erling Smørgrav wrote:
> "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> writes:
> > Dag-Erling Smørgrav <des@des.no> writes:
> >> + /* split address if necessary */
> >> + err = EAI_SYSTEM;
> >> + if ((sep = strchr(addr, ':')) != NULL) {
> >> + len = snprintf(hbuf, sizeof(hbuf),
> >> + "%.*s", (int)(sep - addr), addr);
> > I believe this code is what broke
> > fetch http://[::1]:6666/
> > just to give an example; and the printf traces will not reveal this
> > but “addr” at this point has no more addr:port in it given the
> > function arguments, right?
>
> I think you're right, I'll look into it. It means replacing strchr()
> with a loop. Is there a ticket for this bug, and if not, could you
> please open one?
>
This causes breakage on the cluster for everything using libfetch:
On the jenkins cluster we cannot run anymore fetch inside i386 chroots
# chroot ufs fetch -v http://pkg.freebsd.org
resolving server address: pkg.freebsd.org:80
fetch: http://pkg.freebsd.org: Non-recoverable resolver failure
What is specific is the host only have ipv6 is amd64 and the chroot is i386
I can't figure out the issue can you have a look?
Best regards,
Bapt
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAljE0DwACgkQY4mL3PG3
PloCVBAAqg1bx98kzoBl0nkt0kn5//jKwvw8y5IBVgqO6kmloihvoMItx3JGeGrr
c2UQ9FXyaHI5zpyUBlp5hQnf7KrLKAoqjegqsqqf3maf6eJQBD8L2xfmys50fNjp
7E9xI7vQ3T8jB+CQS3t4oAXRiCGb9Ic3a8bN3vKubA3Ib4Ce4L89e0KHV3p8W3M/
vOJ+2ou9EA9n/2DRW5KcrVCjfdtN0KRf+Lz7zJ5trBJ45sjMPwUI8qDkjUakl+35
YllESg4YyorAyh4+2IVEJP1MBXMO25R5aqNgfGaEKAKc+Td2f5xDvZBDmMORAblY
p7CQvF8kPCGLNN4SJm+5BQkKpPfT0GrUgK0mcS4oiVuCawxo5qXnKF2h5I4e5LwK
5UyuHxwm6wBFIu1Xg6MjDkPep7oABuHYmVHAWHmik2H2fm6Q3OnVe+VzUzwmQYh4
zn3oHU5WIssmDNtfkOCU4w5pS6NuoO1Iv+ZIGzOdcxodO/fRxhez7fxpMdQGqDBG
8791VAy56OsVj/qP/bEpHH+dsLc9cM1eyxDrkeFYbxFuG0sW+vrr99HZjDrym6Ru
vIxfBHHi95IQN1VIc2VzhE+lcUEZVpuppGyk/VrLok2lBbi3NJOp/y6izmuXAFWH
hkKl+uaN5ji4HcoztclHcGifjdB/bAh9z87KEhFHywIg4mYjfA8=
=J3yS
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170312043615.ax5a6xtuf2zmebc2>