Date: Fri, 5 Jun 2009 10:29:56 +0400 From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: John Baldwin <jhb@freebsd.org> Cc: kmacy@freebsd.org, Marius Strobl <marius@alchemy.franken.de>, freebsd-current@freebsd.org, rwatson@freebsd.org, FreeBSD Tinderbox <tinderbox@freebsd.org>, sparc64@freebsd.org, current@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sun4v Message-ID: <Rj7Fi0Uz71tB6gaY5wX5iV4Wqak@XX1fo6zQUfC4h0jjRC6IBz3oNH4> In-Reply-To: <200906040802.27057.jhb@freebsd.org> References: <20090602222445.2F6017302F@freebsd-current.sentex.ca> <20090603194453.GA43137@alchemy.franken.de> <k2BOEYfMcn9Q2wvaWZK0dLZVLhc@BpFm1zkZmHABxHH1eUOcQSRoWTc> <200906040802.27057.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Er1qpsOqk0l6oMce
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Thu, Jun 04, 2009 at 08:02:25AM -0400, John Baldwin wrote:
> On Wednesday 03 June 2009 11:26:17 pm Eygene Ryabinkin wrote:
> > Yes, seems like so. John, may be we can eliminate the only reference to
> > KTR_PERCPU from sys/sys/pcpu.h? Both 'struct pcpu' fields seem to be
> > unused (grep'ped -CURRENT sources).
>
> Yes.
Fine. Then the attached patch should remove the stuff.
--
Eygene
_ ___ _.--. #
\`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
/ ' ` , __.--' # to read the on-line manual
)/' _/ \ `-_, / # while single-stepping the kernel.
`-'" `"\_ ,_.-;_.-\_ ', fsc/as #
_.-'_./ {_.' ; / # -- FreeBSD Developers handbook
{_.-``-' {_/ #
--Er1qpsOqk0l6oMce
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0001-pcpu.h-eliminate-dead-code-with-KTR_PERCPU.patch"
Content-Transfer-Encoding: quoted-printable
=46rom fdb33fbebb9470529fd7dea56905f0454ac53905 Mon Sep 17 00:00:00 2001
=46rom: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Date: Fri, 5 Jun 2009 10:25:52 +0400
Subject: [PATCH] pcpu.h: eliminate dead code with KTR_PERCPU
As per words of John Baldwin,
http://lists.freebsd.org/pipermail/freebsd-current/2009-June/007749.html
and as discovered by grep'ping -CURRENT sources, KTR_PERCPU is not used
anywhere and there is no intention to support it.
Signed-off-by: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
---
sys/sys/pcpu.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/sys/sys/pcpu.h b/sys/sys/pcpu.h
index 98705eb..500657e 100644
--- a/sys/sys/pcpu.h
+++ b/sys/sys/pcpu.h
@@ -76,10 +76,6 @@ struct pcpu {
cpumask_t pc_other_cpus; /* Mask of all other cpus */
SLIST_ENTRY(pcpu) pc_allcpu;
struct lock_list_entry *pc_spinlocks;
-#ifdef KTR_PERCPU
- int pc_ktr_idx; /* Index into trace table */
- char *pc_ktr_buf;
-#endif
#ifdef KTR
char pc_name[PCPU_NAME_LEN]; /* String name for KTR. */
#endif
--=20
1.6.3.1
--Er1qpsOqk0l6oMce--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Rj7Fi0Uz71tB6gaY5wX5iV4Wqak>