Date: Mon, 31 Aug 2020 07:09:12 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Ed Maste <emaste@freebsd.org> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r364321 - head/sbin/ipfw Message-ID: <202008311409.07VE9Ch9033206@gndrsh.dnsmgr.net> In-Reply-To: <CAPyFy2C1F9J5o38RcZHm%2BtD7gXQKxugaPhOfyjOoKem2tKXY=Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Hrm, it seems this reply ended up in my spam folder; sorry for not
> replying until now.
lol Oh, bad filter :-)
> > > *strchr(timestr, '\n') = '\0';
> > > bprintf(bp, "%s ", timestr);
> > ^ Isnt this the +1 space?
> >
> > > } else {
> > > - bprintf(bp, "%*s", twidth, " ");
> > > + bprintf(bp, "%*s", twidth + 1, " ");
> > ^missing from this string?
>
> Inserting an extra space in the format string would also work, sure. I
> considered doing it that way but in the end decided it's not
> materially more clear one way or another, so used the patch as
> submitted.
For me the + 1 leads to a "why is this here", where as the space
in the format string clearly matches the other condition of the else.
Also + 1 causes a run time computation, the extra space does not.
--
Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008311409.07VE9Ch9033206>