Date: Mon, 10 Aug 2020 11:46:44 -0500 From: Kyle Evans <kevans@freebsd.org> To: Warner Losh <imp@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r364030 - in head: . tools/build Message-ID: <CACNAnaHUnU-qHa3wv_sHv8thFVfsE9W%2BicnH651BC=-U8sviGg@mail.gmail.com> In-Reply-To: <202008071626.077GQvd8038727@repo.freebsd.org> References: <202008071626.077GQvd8038727@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 7, 2020 at 11:27 AM Warner Losh <imp@freebsd.org> wrote: > > Author: imp > Date: Fri Aug 7 16:26:56 2020 > New Revision: 364030 > URL: https://svnweb.freebsd.org/changeset/base/364030 > > Log: > The practice of creating symbolic links is somewhat fragile. Always > make copies instead. > > There's too many times that we can't run the new binaries with old > libraries. Making the links when things are known to be 'safe' is a > nice optimization, but a copy of all the binaries is only 30MB, so > saving the copies at the cost of increased support when new symbols > are added and used as part of the bootstrap seems to be unwise. > > There may be additional optimizations possible here, especially for > !FreeBSD hosts. However, that's beyond the scope of the problem I'm > trying to fix with make failing mid-way through an installworld across > change r363679. This optimization there caused us to run a new binary > with an old library once a new make was installed due to the symbolic > link. One could just copy make, but then other binaries fail as well, > so rather than play whack-a-mole, I opted to take us back to the old > way. Before r340157 or so we did copies (thogh of a lot fewer > artifacts), and we didn't have issues like this. > Many thanks for pinpointing the real cause here and solving it! Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHUnU-qHa3wv_sHv8thFVfsE9W%2BicnH651BC=-U8sviGg>