Date: Thu, 16 Sep 2004 04:02:07 -0000 From: Max Laier <max@love2party.net> To: pf4freebsd@freelists.org, Andrew Thompson <andy@fud.org.nz> Subject: [pf4freebsd] Re: pfflowd port Message-ID: <200402240135.55752.max@love2party.net> In-Reply-To: <20040224001503.GA99464@kate.fud.org.nz> References: <20040224001503.GA99464@kate.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 24 February 2004 01:15, Andrew Thompson wrote: > Hi all, > > I have created a port for pfflowd and thought i'd get feedback before > submitting a PR. > > It can be found @ > > http://www.fud.org.nz/pfflowd-port.tar.gz Okay, some feedback: 1) You copied from security/pf (which is okay), but you should update the= =20 pkg-descr. 2) pkg-plist is empty, but should contain: sbin/pfflowd etc/rc.d/pfflowd.sh.sample 3) Not sure what the patch for pfflowd.c should do. What is wrong with th= e=20 check for invalid ports? 4) Maybe get the pidfile.{c,h} from us (include/support/) and add them=20 instead of just removing <util.h> and pidfile support. --=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402240135.55752.max>