Date: Tue, 7 Mar 2017 14:17:33 -0800 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314862 - head/sys/modules/qlxgbe Message-ID: <20170307221733.GN1044@FreeBSD.org> In-Reply-To: <201703071543.v27FhnoL024242@repo.freebsd.org> References: <201703071543.v27FhnoL024242@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote: A> Author: avg A> Date: Tue Mar 7 15:43:49 2017 A> New Revision: 314862 A> URL: https://svnweb.freebsd.org/changeset/base/314862 A> A> Log: A> qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy A> A> The module uses unnamed structure and union fields and base GCC in A> stable/10 doesn't like it. A> I think that that is a C11 feature, so it is courteous of more modern A> compilers to not complain about it when compiling in C99 mode. There are a lot of code in kernel, that uses anonymous structs and unions. This feature is enabled globally. Why does this module need special treatment? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170307221733.GN1044>