Date: Mon, 13 Apr 2020 02:46:17 +0800 From: Li-Wen Hsu <lwhsu@freebsd.org> To: "Alexander V. Chernikov" <melifaro@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: ipdivert tests and net.inet.ip.fw.default_to_accept Message-ID: <CAKBkRUzuOObKunDNfACx7KsfVzbboLnhv2FR2Qi6ywBgG4V%2BRg@mail.gmail.com> In-Reply-To: <6963991586714482@vla4-4046ec513d04.qloud-c.yandex.net> References: <CAKBkRUx%2B5ZKgPtb2hcYOk2-Ddz8BgX8pLoG8yHMuDakMWKKhfw@mail.gmail.com> <6963991586714482@vla4-4046ec513d04.qloud-c.yandex.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 13, 2020 at 2:09 AM Alexander V. Chernikov <melifaro@freebsd.org> wrote: > 12.04.2020, 18:45, "Li-Wen Hsu" <lwhsu@freebsd.org>: > > I'm checking test failures and panics, and found that the two ipdivert > > tests we added previously have never been tested correctly. I've > Yep, I've been running tests manually but haven't managed to raise a pull request to auto-load ipdivert prior to the tests yet. It think it's okay for now. I've merged this PR https://github.com/freebsd/freebsd-ci/pull/34 and now we have loaded all the modules needed. I somehow feel it's crazy and default_to_accept might have side effect like what we already saw. Anyway. I'm leaving them there for now and move to checking other failures and panics first. Also thanks for checking relative codes. That's the reason we need tests!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUzuOObKunDNfACx7KsfVzbboLnhv2FR2Qi6ywBgG4V%2BRg>