Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Jul 2018 18:54:17 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        Matt Macy <mmacy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r335916 - head/sys/conf
Message-ID:  <20180705155417.GI5562@kib.kiev.ua>
In-Reply-To: <6e5bc5e4-052c-877f-1c36-c72e276ff045@FreeBSD.org>
References:  <201807032305.w63N5guY063293@repo.freebsd.org> <20180704142233.GB5562@kib.kiev.ua> <6e5bc5e4-052c-877f-1c36-c72e276ff045@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote:
> On 7/4/18 7:22 AM, Konstantin Belousov wrote:
> > On Tue, Jul 03, 2018 at 11:05:42PM +0000, Matt Macy wrote:
> >> Author: mmacy
> >> Date: Tue Jul  3 23:05:42 2018
> >> New Revision: 335916
> >> URL: https://svnweb.freebsd.org/changeset/base/335916
> >>
> >> Log:
> >>   Enable MODULE_TIED by default for modules compiled with the kernel
> > But why ?
> 
> I think we should enable KLD_TIED to inline critical_* etc. for modules
> built as part of a kernel that are installed alongside the kernel in /boot/<kerneldir>.

> I don't think we need to support modules built with kernel A loaded into kernel B.
> 
This is the crusial point.  I do not object, but this this is a radical
change from the previous mode of modules build.

I do not want to put words in other person mouth, but I beliee that the
original intent of KLD_TIED/MODULE_TIED was much more limited.  Only some
specific modules were to be tied.

> I think we should not enable it for "standalone" module builds done in ports or via
> "cd /sys/modules/foo; make" that install to /boot/modules so that those modules can
> work with different kernels.  This still permits someone to load a module into kernel
> A that they had disabled in kernel A's config file (via NO_MODULES or MODULES_OVERRIDE
> or some such) by doing 'cd /sys/modules/foo; make; make load'.
> 
> -- 
> John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180705155417.GI5562>