Date: Thu, 2 Sep 2010 23:39:26 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Justin T. Gibbs" <gibbs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212160 - in head/sys: cam/ata cam/scsi cddl/contrib/opensolaris/uts/common/fs/zfs geom geom/sched kern sys Message-ID: <20100902213926.GA2542@garage.freebsd.pl> In-Reply-To: <201009021940.o82JeS8M017537@svn.freebsd.org> References: <201009021940.o82JeS8M017537@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2010 at 07:40:28PM +0000, Justin T. Gibbs wrote: > Author: gibbs > Date: Thu Sep 2 19:40:28 2010 > New Revision: 212160 > URL: http://svn.freebsd.org/changeset/base/212160 >=20 > Log: > Correct bioq_disksort so that bioq_insert_tail() offers barrier semanti= c. Thank you for working on this, Justin! > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > sys/geom/geom_io.c > Mark bios with the BIO_FLUSH command as BIO_ORDERED. [...] Don't you think it would be better to set the flag from within g_io_request()? This way every BIO_FLUSH consumer doesn't have to remember to set it. Or am I missing something? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyAGY4ACgkQForvXbEpPzQ3gwCdF0QP84b130HXi+HoDuk2ppKw kv4Anj3WqnLR8uTTKBkrTdnyH0MR9gor =4+At -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100902213926.GA2542>