Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Oct 2012 11:18:42 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Ed Schouten <ed@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r241737 - in head: bin/date bin/ed libexec/rtld-aout sbin/camcontrol sbin/geom/core usr.bin/at usr.bin/calendar usr.bin/chat usr.bin/ctlstat usr.bin/elfdump usr.bin/fetch usr.bin/finger...
Message-ID:  <201210191118.42722.jhb@freebsd.org>
In-Reply-To: <201210191449.q9JEnhfn015510@svn.freebsd.org>
References:  <201210191449.q9JEnhfn015510@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, October 19, 2012 10:49:43 am Ed Schouten wrote:
> Author: ed
> Date: Fri Oct 19 14:49:42 2012
> New Revision: 241737
> URL: http://svn.freebsd.org/changeset/base/241737
> 
> Log:
>   More -Wmissing-variable-declarations fixes.
>   
>   In addition to adding `static' where possible:
>   
>   - usr.sbin/mfiutil: Put global variables in mfiutil.h.

The fw_* changes here probably wasn't the right way to fix this.  The 
variables should be static.  The problem is that 'scan_firmware()' is
duplicated and should probably be reduced to a single copy.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210191118.42722.jhb>