Date: Thu, 13 Nov 2003 12:24:03 -0800 From: Kirk McKusick <mckusick@beastie.mckusick.com> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_timeout.c Message-ID: <200311132024.hADKO3aG009382@beastie.mckusick.com> In-Reply-To: Your message of "Wed, 12 Nov 2003 19:03:07 EST." <Pine.NEB.3.96L.1031112190222.96006B-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Date: Wed, 12 Nov 2003 19:03:07 -0500 (EST) > From: Robert Watson <rwatson@FreeBSD.org> > X-Sender: robert@fledge.watson.org > To: Kirk McKusick <mckusick@FreeBSD.org> > Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org > Subject: Re: cvs commit: src/sys/kern kern_timeout.c > In-Reply-To: <200311122228.hACMSSwZ027025@repoman.freebsd.org> > > On Wed, 12 Nov 2003, Kirk McKusick wrote: > > > mckusick 2003/11/12 14:28:28 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_timeout.c > > Log: > > At the request of several developers, restore the DIAGNOSIC code > > deleted in 1.81. Increase the initial timeout limit to 2ms to > > eliminate spurious messages of excessive timeouts in the NFS > > client code. > > > > Requested by: Poul-Henning Kamp <phk@phk.freebsd.dk> > > Requested by: Mike Silbersack <silby@silby.com> > > Requested by: Sam Leffler <sam@errno.com> > > Could this have been responsible for the apparent hangs some (few but > unfortunate) users were seeing with NFS, frequently accompanied by notices > that the NFS server was unreachable? > > Robert N M Watson FreeBSD Core Team, TrustedBSD Projects > robert@fledge.watson.org Network Associates Laboratories The above code is only included when DIAGNOSTIC is defined and is purely diagnostic (printing out a warning when an event called from the timeout queue takes longer than the threshhold: formerly 1ms now 2ms). So, at best it might have provided a warning. It certainly could not have caused/fixed the problem. Kirk McKusick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311132024.hADKO3aG009382>