Date: Thu, 30 May 2013 08:00:02 GMT From: Mark Linimon <linimon@lonesome.com> To: freebsd-net@FreeBSD.org Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap macro expansion Message-ID: <201305300800.r4U802sw090891@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/179083; it has been noted by GNATS. From: Mark Linimon <linimon@lonesome.com> To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap macro expansion Date: Thu, 30 May 2013 02:58:04 -0500 ----- Forwarded message from Luigi Rizzo <rizzo@iet.unipi.it> ----- Date: Thu, 30 May 2013 09:57:15 +0200 From: Luigi Rizzo <rizzo@iet.unipi.it> To: freebsd-bugs@freebsd.org, freebsd-net@freebsd.org Subject: Re: kern/179083: [netmap] [patch] Invalid index calucation in netmap macro expansion User-Agent: Mutt/1.5.20 (2009-06-14) Thanks for the report. The macro is correct as implemented. The problem, in case, is in the description in netmap_user.h which is confusing and should be improved as follows: -* char *buf = NETMAP_BUF(ring, index) returns a pointer to -* the i-th buffer +* char *buf = NETMAP_BUF(ring, x) returns a pointer to +* the buffer numbered 'x' This will be committed soon, so please close the PR cheers luigi ----- End forwarded message -----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305300800.r4U802sw090891>