Date: Fri, 20 Dec 2013 16:37:45 -0800 From: Justin Hibbits <chmeeedalf@gmail.com> To: Howard Su <howard0su@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Justin Hibbits <jhibbits@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org> Subject: Re: svn commit: r259668 - head/sys/cddl/dev/fbt Message-ID: <20131220163745.479cb59d@zhabar.gateway.2wire.net> In-Reply-To: <CAAvnz_ps7yopHJZAKwzppjqmaunkM9zKOrrmGGCMNcVapD=4Kw@mail.gmail.com> References: <201312202318.rBKNIFbS097430@svn.freebsd.org> <CAAvnz_ps7yopHJZAKwzppjqmaunkM9zKOrrmGGCMNcVapD=4Kw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 21 Dec 2013 08:31:01 +0800 Howard Su <howard0su@gmail.com> wrote: > On Saturday, December 21, 2013, Justin Hibbits wrote: > > > Author: jhibbits > > Date: Fri Dec 20 23:18:14 2013 > > New Revision: 259668 > > URL: http://svnweb.freebsd.org/changeset/base/259668 > > > > Log: > > Fix a couple bugs in FBT PowerPC. Clamp the size to a > > 'instruction size' not > > 'byte size', and fix a typo. > > > > MFC after: 2 weeks > > > > Modified: > > head/sys/cddl/dev/fbt/fbt_powerpc.c > > > > Modified: head/sys/cddl/dev/fbt/fbt_powerpc.c > > > > ============================================================================== > > --- head/sys/cddl/dev/fbt/fbt_powerpc.c Fri Dec 20 21:31:50 2013 > > (r259667) > > +++ head/sys/cddl/dev/fbt/fbt_powerpc.c Fri Dec 20 23:18:14 2013 > > (r259668) > > @@ -219,7 +219,7 @@ fbt_provide_module_function(linker_file_ > > return (0); > > > > instr = (u_int32_t *) symval->value; > > - limit = (u_int32_t *) (symval->value + symval->size); > > + limit = (u_int32_t *) (symval->value + symval->size / > > sizeof(u_int32_t)); > > > > This change doesn't look right to me. symval->value is caddr_t > > (char*). > why add instruction size to it? D'oh, complete brain-o. I had read it as a size field, not a pointer field. Fixed now. - Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131220163745.479cb59d>