Date: Thu, 10 May 2018 00:13:12 +0200 From: Mariusz Zaborski <oshogbo@FreeBSD.org> To: Ian Lepore <ian@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333438 - head/sbin/geom/class/eli Message-ID: <20180509221312.GA27592@x-wing> In-Reply-To: <1525899943.35372.42.camel@freebsd.org> References: <201805092051.w49KpGZm079239@repo.freebsd.org> <1525899943.35372.42.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--5vNYLRcllDrimb99 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 09, 2018 at 03:05:43PM -0600, Ian Lepore wrote: > On Wed, 2018-05-09 at 20:51 +0000, Mariusz Zaborski wrote: > > Author: oshogbo > > Date: Wed May=A0=A09 20:51:16 2018 > > New Revision: 333438 > > URL: https://svnweb.freebsd.org/changeset/base/333438 > >=20 > > Log: > > =A0 Change option dry-run from 'n' to 'C' in geli attach command. > > =A0=A0 > > =A0 'n' is used in other commands to define the key index. > > =A0 We should be consistent with that. > > =A0 'C' option is used by patch(1) to perform dryrun so lets use that. >=20 > This seems like a dangerous change. Today I am begining to write new > product image creation scripts that involve geli, and I'm going to do > so under the assumption that the commands and arguments are not going > to suddenly change their meaning on some future OS update. >=20 > Hopefully the new meaning of -n implies an argument which is validated > as being either 0 or 1, so that any existing scripts that contain -n to > mean "dry run" will very likely fail the validation and not silently > misbehave. >=20 > At the very least, it seems like an entry in UPDATING is required. Oliver, Ian - thank you for noticing this. I wasn't sure if we need to add UPDATING or release notes because I added '= n' option couple weeks ago and wasn't integrated to any stable/release branch. Considering that should we still update UPDATING? Thanks, --=20 Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD commiter | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 --5vNYLRcllDrimb99 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkD1x0xkJXVVY1Gwf38KEGuLGxWQFAlrzcmoACgkQ38KEGuLG xWSl/w/+KmElVSTFKE1NpcRlG2ozz/TbzMl0s6OGb2JpOMEHVT+tsQUsdJFA+wgD OQOHhwHgKkp/4IosU3HdwfcvuqjuHDcfQLLvl0bue0HwdjiRc1BvNBFyx9AVgCzr pVv/W/Ymp6PjuyT7lKMpX4UQ7RZV3BCVPq0nGnzkJ/sf5VPnaQId/S3IupaaRpTg juyJ2vgdT/hG8+jRlpk2YeBXsiOBf2dQo8iQEn7EjG36RSQQq9pSA9SV3Q3H74b+ or/Td9b9IuWzBLZdmb9DVImwrI20ICV9SA4QvEmqtD2dct+eaiIlESn26Pj2Q+3Y KK2BhZxupY2Oq6p2wRV2SBvtDS0iYKH76EJHzehFq5ZfL0p2lKCs5bDO5i4BMsZb zj4lFz2uC1MwUNPwAVdv+cGTB/vKUUrttK4pWMdFH9394dOhoTaI+r89QrU2GINg HUt3Ld+45beR1xjYsVmil+On7qN/Is22QiWQMdvZh0pddRTcvX4oXQ+bXGLnWNdD RVSiYK2s6pzAYTxz//8pmxImg+ACJ1tZfhB6gIYrrLfGygwjG0Ey2Z2F4IiDyhnY 2Dco6Dhq3zbiIg5Ds3VSCUA3XbBobyzfKAQSQOkDzJbpOXd4qresaLQFfNIUvuvZ UJLMYo9v3pEvdbDmMM4YpCVFfEkKYNDpSRGzycmNoBWkMWTFB1I= =fK5p -----END PGP SIGNATURE----- --5vNYLRcllDrimb99--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180509221312.GA27592>