Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 1 Aug 2000 03:25:35 -0700
From:      "James Johnson" <bonk1138@msn.com>
To:        <freebsd-current@freebsd.org>
Subject:   netinet compile broken
Message-ID:  <KJEDKFEKMMFFMPFPBLJHEEEJCHAA.bonk1138@msn.com>

next in thread | raw e-mail | index | archive | help

	sys/netinet/ip_fil.c appears to be busted. Trying to recompile kernel
modules breaks as follows:

===> ipfilter
<SNIP>

cc -O -pipe -DIPFILTER=1 -DIPFILTER_LKM -DIPFILTER_LOG  -D_KERNEL -Wall -Wre
dundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wp
ointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi -DKLD_MODULE -n
ostdinc -I-  -I. -I@ -I@/../include  -mpreferred-stack-boundary=2 -c
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c: In function
`iplattach':
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c:272: too few arguments
to function `pfil_add_hook'
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c: In function
`ipldetach':
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c:384: too few arguments
to function `pfil_remove_hook'
*** Error code 1

Looks like two else statements were commented out. This simple diff fixes it

--- ip_fil.c	Tue Aug  1 00:04:24 2000
+++ ip_fil.bak	Tue Aug  1 03:18:08 2000
@@ -268,7 +268,7 @@
 		return error;
 #   endif
 	}
-#  else
+  else
 	pfil_add_hook((void *)fr_check, PFIL_IN|PFIL_OUT);
 #  endif
 #  ifdef USE_INET6
@@ -380,7 +380,7 @@
 				 &inetsw[ip_protox[IPPROTO_IP]].pr_pfh);
 	if (error)
 		return error;
-#  else
+	  else
 	pfil_remove_hook((void *)fr_check, PFIL_IN|PFIL_OUT);
 #  endif
 #  ifdef USE_INET6





To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?KJEDKFEKMMFFMPFPBLJHEEEJCHAA.bonk1138>