Date: Mon, 18 Aug 2003 13:19:07 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Pawel Jakub Dawidek <nick@garage.freebsd.pl> Cc: Robert Watson <rwatson@FreeBSD.org> Subject: Re: PERFORCE change 35655 for review Message-ID: <XFMail.20030818131907.jhb@FreeBSD.org> In-Reply-To: <20030816164300.GS395@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16-Aug-2003 Pawel Jakub Dawidek wrote: > On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote: > +> - mode ~= cmask; > +> + mode = mode &~ cmask; > > IMHO this is a style bug. > > This should be: mode = mode & ~cmask; > > On time, when I was tired, I've spend few minutes wondering why 'foo' > after this operation isn't equal to 'foo - bar':) > > foo =- bar; I prefer 'mode &= ~cmask' myself. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030818131907.jhb>