Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Nov 2025 16:44:29 -0800
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Warner Losh <imp@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: ddec4209b10d - main - ipfilter: fix broken build
Message-ID:  <20251127004429.2367C18D@slippy.cwsent.com>
In-Reply-To: <692795d5.d406.41ba701c@gitrepo.freebsd.org>
References:  <692795d5.d406.41ba701c@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

In message <692795d5.d406.41ba701c@gitrepo.freebsd.org>, Warner Losh writes:
> The branch main has been updated by imp:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=ddec4209b10d65ef19e1d1b884e1b876
> eab58c7d
>
> commit ddec4209b10d65ef19e1d1b884e1b876eab58c7d
> Author:     Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2025-11-27 00:04:29 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2025-11-27 00:05:35 +0000
>
>     ipfilter: fix broken build
>     
>     Every commit earns me a dozen emails that LINT is broken. This should
>     stop that.
>     
>     Fixes: eda1756d0454f ipfilter: Verify frentry on entry into kernel
>     Sponsored by: Netflix

Thank you.

Sorry for the breakage.

> ---
>  sys/netpfil/ipfilter/netinet/fil.c    | 4 +---
>  sys/netpfil/ipfilter/netinet/ip_nat.c | 3 ---
>  2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/sys/netpfil/ipfilter/netinet/fil.c b/sys/netpfil/ipfilter/netine
> t/fil.c
> index 0de5378322df..0c5e22517dc4 100644
> --- a/sys/netpfil/ipfilter/netinet/fil.c
> +++ b/sys/netpfil/ipfilter/netinet/fil.c
> @@ -4413,9 +4413,7 @@ frrequest(ipf_main_softc_t *softc, int unit, ioctlcmd_t
>  req, caddr_t data,
>  	void *ptr, *uptr;
>  	u_int *p, *pp;
>  	frgroup_t *fg;
> -	char *group, *name;
> -	size_t v_fr_size, v_element_size;
> -	int v_rem_namelen, v_fr_toend;
> +	char *group;
>  
>  	ptr = NULL;
>  	fg = NULL;
> diff --git a/sys/netpfil/ipfilter/netinet/ip_nat.c b/sys/netpfil/ipfilter/net
> inet/ip_nat.c
> index d83454185609..b8602db91820 100644
> --- a/sys/netpfil/ipfilter/netinet/ip_nat.c
> +++ b/sys/netpfil/ipfilter/netinet/ip_nat.c
> @@ -978,9 +978,6 @@ ipf_nat_ioctl(ipf_main_softc_t *softc, caddr_t data, ioct
> lcmd_t cmd,
>  	int interr_tbl[3] = { 60077, 60081, 60078 };
>  	ipnat_t *nat, *nt, *n;
>  	ipnat_t natd;
> -	char *name;
> -	size_t v_in_size, v_element_size;
> -	int v_rem_namelen, v_in_toend;
>  	SPL_INT(s);
>  
>  #if !SOLARIS && defined(_KERNEL)
>


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e**(i*pi)+1=0




help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20251127004429.2367C18D>