Date: Thu, 9 Jan 2014 16:09:52 -0800 From: "Simon J. Gerraty" <sjg@juniper.net> To: Julio Merino <julio@meroh.net> Cc: freebsd-testing@freebsd.org, sjg@juniper.net Subject: Re: Fixing installation of Kyuafiles Message-ID: <20140110000952.3F2BF5807E@chaos.jnpr.net> In-Reply-To: <20140109233402.GA8193@fbair.virtual.network> References: <20140109233402.GA8193@fbair.virtual.network>
next in thread | previous in thread | raw e-mail | index | archive | help
>The bin/sh and bin/test tests are broken because they cannot be run as root, >yet the testing machines are currently running stuff as root. This is easy >to fix by adding a require_user="unprivileged" property to the tests. > >I was going to fix this by adding manually-crafted Kyuafile files that do >the above in bin/sh/tests/ and bin/test/tests/ and setting KYUAFILE=yes in >the corresponding Makefile files... but unfortunately that does not work >with NO_CLEAN builds. is the issue limited to just those dirs? >The problem is that bsd.test.mk generates Kyuafile files in the obj directory >and setting KYUAFILE=yes means that make will _still_ see the Kyuafile in the >obj directory and not the one that just appeared in src. > >Does the attached patch seem reasonable to prevent this in the future? This seems a reasonable change.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140110000952.3F2BF5807E>