Date: Sun, 1 Feb 2009 13:37:49 -0800 From: Andrew Thompson <thompsa@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r187978 - user/thompsa/usb/sys/dev/usb2/ethernet Message-ID: <20090201213749.GJ32503@citylink.fud.org.nz> In-Reply-To: <20090201.142808.886478999.imp@bsdimp.com> References: <200902010650.n116obU1045871@svn.freebsd.org> <20090201.142808.886478999.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 01, 2009 at 02:28:08PM -0700, M. Warner Losh wrote: > In message: <200902010650.n116obU1045871@svn.freebsd.org> > Andrew Thompson <thompsa@FreeBSD.org> writes: > : + locked = mtx_owned(&sc->sc_mtx); > : + if (!locked) > : + AUE_LOCK(sc); > > You do know this is racy, right? Yea... It only get called unlocked during mii probe+attach so its fine. I havnt actaully checked if its ok to hold a mutex during mii_phy_probe() which would make this go away. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090201213749.GJ32503>