Date: Wed, 23 Dec 2015 19:05:50 -0700 From: Alan Somers <asomers@freebsd.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r292675 - projects/zfsd/head/share/mk Message-ID: <CAOtMX2i1hLs3QKOxCoOOg-_beQEr3j1vT5uL_j81p5OadPJviA@mail.gmail.com> In-Reply-To: <C47C4598-67DF-4DED-BFF4-BDFC460A7AD6@gmail.com> References: <201512232335.tBNNZXra019877@repo.freebsd.org> <C47C4598-67DF-4DED-BFF4-BDFC460A7AD6@gmail.com>
index | next in thread | previous in thread | raw e-mail
On Wed, Dec 23, 2015 at 5:02 PM, NGie Cooper <yaneurabeya@gmail.com> wrote: > >> On Dec 23, 2015, at 15:35, Alan Somers <asomers@FreeBSD.org> wrote: >> >> Author: asomers >> Date: Wed Dec 23 23:35:32 2015 >> New Revision: 292675 >> URL: https://svnweb.freebsd.org/changeset/base/292675 >> >> Log: >> Fix typo from r292666 >> >> Sponsored by: Spectra Logic Corp >> >> Modified: >> projects/zfsd/head/share/mk/atf.test.mk >> >> Modified: projects/zfsd/head/share/mk/atf.test.mk >> ============================================================================== >> --- projects/zfsd/head/share/mk/atf.test.mk Wed Dec 23 22:45:17 2015 (r292674) >> +++ projects/zfsd/head/share/mk/atf.test.mk Wed Dec 23 23:35:32 2015 (r292675) >> @@ -95,7 +95,7 @@ CLEANFILES+= ${_T} ${_T}.tmp >> ATF_TESTS_KSH93_SED_${_T}?= # empty >> ATF_TESTS_KSH93_SRC_${_T}?= ${_T}.sh >> ${_T}: ${ATF_TESTS_KSH93_SRC_${_T}} >> - echo '#! /usr/libexec/atf-sh' > ${.TARGET}.tmp >> + echo '#! /usr/libexec/atf-ksh93' > ${.TARGET}.tmp >> .if empty(ATF_TESTS_KSH93_SED_${_T}) >> cat ${.ALLSRC:N*Makefile*} >>${.TARGET}.tmp >> .else > > Hi Alan, > I’ve been watching some of these commits — I was wondering if you’d be for taking all of the IllumOS specific testcase logic out of atf.test.mk (to keep it “clean” per se) and be open to putting this into a separate .test.mk file, similar to the one that Mark Johnston started for dtrace: ^/head/cddl/usr.sbin/dtrace/tests/dtrace.test.mk ? > Thanks! > -NGie Yeah, I think we can do that. It hadn't occured to me to use separate .mk files for a subdirectory of tests. -Alanhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2i1hLs3QKOxCoOOg-_beQEr3j1vT5uL_j81p5OadPJviA>