Date: Thu, 1 Sep 2011 01:02:01 -0700 From: Trent Nelson <trent@snakebite.org> To: Attilio Rao <attilio@freebsd.org> Cc: "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org> Subject: Re: panic: spin lock held too long (RELENG_8 from today) Message-ID: <363D7137-CC1E-45F6-927C-98201BCDF397@snakebite.org> In-Reply-To: <CAJ-FndDHmwa%2B=LNGgU%2B5MK2Xmtj8kWHB10JsoytkMGEtVgncYw@mail.gmail.com> References: <20110818.091600.831954331552558249.hrs@allbsd.org> <CAJ-FndCL70m41dQ9FPmzUg0V8a9JacvLOnjmMQL=3PfN7NmPfQ@mail.gmail.com> <20110818025550.GA1971@libertas.local.camdensoftware.com> <20110819.092811.1087267565626420460.hrs@allbsd.org> <20110819003759.GC54831@libertas.local.camdensoftware.com> <4E4E5D49.4040502@sentex.net> <CAJ-FndDHmwa%2B=LNGgU%2B5MK2Xmtj8kWHB10JsoytkMGEtVgncYw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Aug 19, 2011, at 7:53 PM, Attilio Rao wrote: > If nobody complains about it earlier, I'll propose the patch to re@ in 8 hours. Just a friendly 'me too', for the records. 22 hours of heavy network/disk I/O and no panic yet -- prior to the patch it was a panic orgy. Any response from re@ on the patch? It didn't appear to be in stable/8 as of yesterday: [root@flanker/ttypts/0(../src/sys/kern)#] svn diff Index: kern_timeout.c =================================================================== --- kern_timeout.c (revision 225280) +++ kern_timeout.c (working copy) @@ -268,9 +268,11 @@ CC_LOCK_ASSERT(cc); c->c_cpu = CPUBLOCK; + spinlock_enter(); CC_UNLOCK(cc); new_cc = CC_CPU(new_cpu); CC_LOCK(new_cc); + spinlock_exit(); c->c_cpu = new_cpu; return (new_cc); } Regards, Trent.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?363D7137-CC1E-45F6-927C-98201BCDF397>