Date: Sun, 2 Mar 2014 16:14:30 -0500 From: Julio Merino <jmmv@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Jilles Tjoelker <jilles@stack.nl> Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF Message-ID: <CAFY7cWCBGmZA1GdSNwNPcSeu_vLTHkSs0aMk3sb6sMs2H-Gn8Q@mail.gmail.com> In-Reply-To: <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> References: <B5290C1B-F262-479C-8D4F-A5D8B3CE5A52@gmail.com> <20140124162759.GB90996@stack.nl> <CADyfeQUfxi43A4aXg%2Bdu1oGkQAjJFYH1CCXSSoaLKz8nX2hapw@mail.gmail.com> <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 27, 2014 at 5:02 AM, Garrett Cooper <yaneurabeya@gmail.com> wrote: > Hi all, > Here's the next patch for converting bin/sh/tests over to ATF. I've tried to incorporate all input from folks about simplifying the integration scripts and removing valid_osreldate functionality. Apologies for the really long delay... I suppose nothing has changed given that there were no replies to this. Soooo, some more comments: * Could functional_test be created with ATF_TESTS_SH ? * Rename the script in subversion to functional_test.sh (including the extension). * Do NOT cd out of the current work directory in functional_test, anywhere. This breaks all the assumptions in tests regarding the ability to write to the current work directory without caring about cleaning up. * Use atf_get_srcdir to locate where the data files are, not dirname $0. * Continue to use SUBDIR, not ATF_TESTS_SUBDIRS. The latter does not exist. * Reintroduce $FreeBSD$ to functional_test.sh. * The empty Makefiles in all the subdirectories are quite confusing. At the very least, explicitly define TESTSDIR as is customary everywhere else. * I'm still afraid of all this "auto-discovery" of test cases based on files, because it is quite confusing... but at least it's now a bit more self-contained and easier to strip out later. So we could keep it. * The FILES must continue to be installed. Does this actually work when running your test programs after a "make install"? Cheers
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWCBGmZA1GdSNwNPcSeu_vLTHkSs0aMk3sb6sMs2H-Gn8Q>