Date: Wed, 22 Aug 2018 09:18:13 +0100 From: Johannes Lundberg <johalun0@gmail.com> To: jhb@freebsd.org Cc: Hans Petter Selasky <hps@selasky.org>, Matthew Macy <mmacy@freebsd.org>, Andriy Gapon <avg@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338172 - in head: . sys/amd64/conf sys/dev/drm sys/dev/drm2 sys/dev/drm2/i915 sys/dev/drm2/radeon sys/dev/drm2/radeon/reg_srcs sys/dev/drm2/ttm sys/i386/conf sys/modules sys/modules/dr... Message-ID: <CAECmPwuPpHZnBEjTGA8g1H9nJLffhtq-EKCzNC-H0w6q_7D7dw@mail.gmail.com> In-Reply-To: <860aa5fa-1004-c19e-b928-1cbcc2c90f6f@FreeBSD.org> References: <201808220150.w7M1oDeA012487@repo.freebsd.org> <bad9d7c2-2c69-4c1e-fb40-c5dee38d77a1@FreeBSD.org> <CAPrugNq889GHwQv7sXrzRYUZ=GKi8qa9_%2BHky_TOerHz4LKYLA@mail.gmail.com> <13c977be-0ee7-688d-4f61-837ccb5d5273@selasky.org> <860aa5fa-1004-c19e-b928-1cbcc2c90f6f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 22, 2018 at 8:51 AM John Baldwin <jhb@freebsd.org> wrote:
> On 8/22/18 8:41 AM, Hans Petter Selasky wrote:
> > On 8/22/18 9:35 AM, Matthew Macy wrote:
> >> Johannes - do you know off hand?
> >> -M
> >
> > Hi,
> >
> > This function is still not implemented. This is part of the LGPLv2 part.
> >
>
Yeah, I confused it with another function...
> Probably the function and the restore companion doesn't have to panic.
> >
> > --HPS
> >
> >> static inline void
> >> linux_pci_save_state(struct pci_dev *pdev)
> >> {
> >>
> >> panic("implment me!!");
> >> UNIMPLEMENTED();
> >> }
>
> Can't this just use pci_save_state() of the FreeBSD device_t? If there
> are bits of PCI space that pci_save_state() isn't saving that we need to
> save/restore, we should probably just add those to the FreeBSD one
> (e.g. additional capability registers).
>
Yes, it seems i915 has been patched to do just this. We can have the
linux_* functions call the freebsd equivalent so that will fix amd/radeon.
> --
> John Baldwin
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAECmPwuPpHZnBEjTGA8g1H9nJLffhtq-EKCzNC-H0w6q_7D7dw>