Date: Thu, 28 Feb 2002 18:36:07 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: Mikhail Teterin <mi@aldan.algebra.com>, <brooks@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/awi if_awi_pccard.c Message-ID: <20020228182700.L51838-100000@gamplex.bde.org> In-Reply-To: <20020227094511.A546@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 27 Feb 2002, Brooks Davis wrote: > On Wed, Feb 27, 2002 at 10:56:38PM +1100, Bruce Evans wrote: > > This an indication that if_name should have type "const char *", and > > that we don't have -Wwrite-strings turned on for the kernel yet. > > If you have a suggestion for a less bogus interim fix, I'd be happy to > commmit it. I guess this one is OK for an interim fix, since we will get warnings about it later when we enable -Wwrite-strings and many other network drivers have similar code. I slightly prefer the changed version anyway. device_get_name() isn't all that useful in places that know the device name. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020228182700.L51838-100000>