Date: Mon, 1 Mar 2010 21:34:35 -0800 From: Juli Mallett <jmallett@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r204507 - in user/jmallett/octeon/sys/mips: include mips Message-ID: <eaa228be1003012134y5e3fb38fl84c5b5463d27d2eb@mail.gmail.com> In-Reply-To: <20100301.223049.864843819497816567.imp@bsdimp.com> References: <201003010521.o215LZqd002772@svn.freebsd.org> <20100301.223049.864843819497816567.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 1, 2010 at 21:30, M. Warner Losh <imp@bsdimp.com> wrote: > In message: <201003010521.o215LZqd002772@svn.freebsd.org> > =A0 =A0 =A0 =A0 =A0 =A0Juli Mallett <jmallett@freebsd.org> writes: > : Author: jmallett > : Date: Mon Mar =A01 05:21:35 2010 > : New Revision: 204507 > : URL: http://svn.freebsd.org/changeset/base/204507 > : > : Log: > : =A0 o) Adjust ptr and register macros for assembly wrt ABI in a way tha= t ought to > : =A0 =A0 =A0work better. =A0Need to check for places where the assembly = assumes pointers > : =A0 =A0 =A0are register width, I guess. > > NetBSD has much better asm.h foo, which I'd hoped to import to help > with this problem... I think that's a great idea =97 especially now that they have n32 and n64 support. Likewise for their PIC and GP macros. In general I'd hope to have time to spend cleaning up mips/include =97 I took a swipe at some KSEG related things, for example. There's a lot of duplication and a large number of vestigal interfaces, types and declarations. The duplication is especially worrying as we move towards 64-bit support, where a stray macro in an underused port can be terribly hard to track down as the source of corruption or invalid addresses. Juli.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?eaa228be1003012134y5e3fb38fl84c5b5463d27d2eb>