Date: Fri, 14 Feb 2020 17:29:14 +0800 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r357867 - head/tests/sys/net Message-ID: <CAKBkRUyGc%2BrQ_415xs3DXAJf6nTPsXRcPXsZh4WXHWBajEq9Rw@mail.gmail.com> In-Reply-To: <20200213213322.GL4808@kib.kiev.ua> References: <202002131905.01DJ5Ja6044695@repo.freebsd.org> <20200213213322.GL4808@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 14, 2020 at 5:33 AM Konstantin Belousov <kostikbel@gmail.com> wrote: > On Thu, Feb 13, 2020 at 07:05:19PM +0000, Li-Wen Hsu wrote: > > -#define RANDOM_MAX ((1<<31) - 1) > > +#define RANDOM_MAX (((long)1<<31) - 1) > This still gives UB on ILP32 platforms. I believe the better fix would be > (1u << 31) - 1. Thanks for pointing this out. It is fixed this in r357904. Li-Wen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUyGc%2BrQ_415xs3DXAJf6nTPsXRcPXsZh4WXHWBajEq9Rw>